Repository navigation
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces robust retry logic with exponential backoff for transient upstream LLM errors (such as 503 and 429) across CI test runners and Go integration tests. It also enhances test isolation and reliability in concurrent environments by generating unique run IDs for database tables, targeting cleanup to those IDs (while pruning stale tables older than an hour), and using 'DROP TABLE IF EXISTS'. Additionally, server lifecycle management in tests is simplified and made safer: 'StartCmd' now returns a unified cleanup function that handles graceful shutdown, port release, and idle HTTP connection dropping, which is verified by a new sequential integration test. I have no additional feedback to provide as there are no review comments.
… and sample 503 retries
d31989a to
5d3f531
Compare
Yuan325
left a comment
There was a problem hiding this comment.
This PR seems to be addressing multiple items, appreciate if you can split them to multiple PRs for easier reviews. Thank you
|
🧨 Preview deployments removed. Cloudflare Pages environments for |
Description
Fixes five classes of CI test flakes across PR and post-merge Cloud Build runs:
PR Checklist
CONTRIBUTING.md
bug/issue
before writing your code! That way we can discuss the change, evaluate
designs, and agree on the general idea
review
!if this involve a breaking change🛠️ Fixes #<issue_number_goes_here>